smooth scroll #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For browsers that support it. There's a [polyfill](https://github.com/wessberg/scroll-behavior-polyfill) but I'm not sure this is important enough to complicate the code for. We can just wait for Safari and Edge to catch up.
- highlight fades in and out - border is displayed on browsers that don't support #RGBA (i.e., Edge)
This setting breaks up URLs, but doesn't break mid-word like "More in formation."
eostrom
force-pushed
the
smooth-scroll-2
branch
from
7e90944 to
9ff55ae
Compare
Author
|
Please disregard. Now that your code has been merged I'll retarget rosslh/master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like you and I were working on the same issue (rosslh#6). Rather than open a separate, competing PR, I merged my changes with yours: