Update Rakefile to fix syntax error for ruby versions below 2.3 #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jellybob Any chance you'd be able to merge this? There's a few gems with broken CI pipelines until this is fixed. |
|
Can we get an update as to when this will be merged in? |
|
@jellybob Any word on this? |
|
Please merge this!!! |
stephenlawrence
added a commit
to stephenlawrence/mimemagic
that referenced
this pull request
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the fix for ruby version 2.1 and 2.2. Also we need it in release 0.3.x to fulfil other gem's dependencies. For example paperclip 5.0.0 depends on mimemagic 0.3.0.
Hopefully it resolves #142