Tests: Use new task runner #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuspagnuolo
previously approved these changes
Nov 4, 2025
| to: inputs.token, | ||
| chainId: inputs.chainId, | ||
| data: '0x70a08231', // `balanceOf` fn selector | ||
| fnSelector: '0x70a08231', // `balanceOf` |
Member
There was a problem hiding this comment.
Would it be possible to simply specify the name of the fn here? Having the selector and the params below with their types sound redundant.
We can create a separate issue to tackle this if possible, I'm not considering it part of this issue
Member
Author
There was a problem hiding this comment.
Yes, it's possible. We can calculate the selector using the ABI, and get the params types from there.
I've just created the issue.
facuspagnuolo
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on mimic-protocol/tooling#162