Fix: Invalid names for ollama-based profiles#691
Open
yoava7 wants to merge 2 commits intomindcraft-bots:developfrom
Open
Fix: Invalid names for ollama-based profiles#691yoava7 wants to merge 2 commits intomindcraft-bots:developfrom
yoava7 wants to merge 2 commits intomindcraft-bots:developfrom
Conversation
Contributor
|
No? None of the things you mentioned are broken. The profiles work as-is, I tested them when I made them to ensure Andy-4-reasoning.json actually made the model think. |
Author
|
Are you sure the profiles still work currently? Maybe I misconfigured something but whenever I enable one of those profiles I get the message Looking at the git history the profiles were made 5 months ago, and the connection handler was created last month. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the addition of the name validation in
src/agent/connection_handler.js, the andy-4 and andy-4-reasoning profiles now have an invalid name due to using a hyphen.I made the minimal change to change their
namefield to use underscores instead, like what is used in claude_thinker, this lets the bots connect to a server and function.I wasn't sure whether it would be better to also change the filename of the profile, as the model itself has a hyphen-- I'll leave that up to you :D
Note: andy-4-reasoning does not currently have a commented out profile in the profiles list in
settings.js, that might be something to consider adding. The filename for it is also andy-4-reasoning, but the name is andy-4-thinking.