Update call to entitlements to avoid deprecated duration #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickc-el
commented
Mar 6, 2025
Comment on lines
+23
to
+24
| Gemspec/DevelopmentDependencies: | ||
| EnforcedStyle: gemspec No newline at end of file |
Author
There was a problem hiding this comment.
There are dev dependencies declared in the gemspec. Instead of changing the structure of the gem I modified the enforced style
erickc-el
commented
Mar 6, 2025
| protected | ||
|
|
||
| def perform(method:, path:, key:, headers: {}, body: nil, &block) | ||
| def perform(method:, path:, key:, headers: {}, body: nil, &block) # rubocop:disable Metrics/AbcSize |
Author
There was a problem hiding this comment.
CI was failing, I disabled this rule here instead of changing the entire library
erickc-el
commented
Mar 6, 2025
| end | ||
|
|
||
| def get_or_create(&block) # rubocop:disable Naming/AccessorMethodName | ||
| def get_or_create(&block) |
erickc-el
commented
Mar 6, 2025
| def grant_promotional(duration:, start_time_ms: nil, &block) | ||
| def grant_promotional(start_time_ms: nil, end_time_ms: nil, &block) | ||
| body = { | ||
| duration: duration, |
Author
There was a problem hiding this comment.
I preferred to remove the duration to avoid any usage. This entailed creating a commit in this repo instead of merging the commit from the fork parent
erickc-el
commented
Mar 6, 2025
| def list(platform, &block) | ||
| response = perform(method: :get, path: path.to_s, headers: { 'x-platform': platform.to_s }, key: :public, &block) | ||
| response = | ||
| perform(method: :get, path: path.to_s, headers: { 'x-platform': platform.to_s }, key: :public, &block) |
Girardvjonathan
approved these changes
Mar 6, 2025
|
@erickc-el I think we could also just drop tarpoon if it becomes a chore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duration param is now deprecated in Stripe API v1, instead we will be using end_time_ms
I decided to create the commit myself instead of keeping up to date with the fork because: