-
Notifications
You must be signed in to change notification settings - Fork 3
Update to 1.21(.1) #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Fourmisain, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the project to Minecraft version 1.21.1. It involves changes to the .minepkg-lock.toml, gradle.properties, minepkg.toml, RuleBookGUI.java, and TestUtils.java files. The primary changes include updating Minecraft and Fabric versions, updating mapping versions, and replacing new Identifier with Identifier.of or Identifier.ofVanilla in the Java code.
Highlights
- Version Update: The Minecraft version has been updated to 1.21.1 across multiple configuration files.
- Code Modernization: Instances of
new Identifierhave been replaced with the recommendedIdentifier.oforIdentifier.ofVanillamethods. - Dependency Updates: Fabric and libgui versions have been updated to compatible versions for Minecraft 1.21.
Changelog
Click here to see the changelog
- .minepkg-lock.toml
- Updated Minecraft version from 1.20.6 to 1.21.1.
- Updated fabric version from 0.100.8+1.20.6.mpkg.1 to 0.115.2+1.21.1.mpkg.1.
- Updated mapping from 1.20.6+build.3 to 1.21.1+build.3.
- Updated the SHA256 hash and URL for the fabric dependency.
- gradle.properties
- Updated minecraft_version from 1.20.6 to 1.21.
- Updated yarn_mappings from 1.20.6+build.3 to 1.21+build.9.
- Updated fabric_version from 0.100.8+1.20.6 to 0.102.0+1.21.
- Updated libgui_version from 10.0.0+1.20.6 to 11.1.0+1.21.
- Updated minecraft_version_range from 1.20.6 to >=1.21 <=1.21.1.
- minepkg.toml
- Updated minecraft requirement from 1.20.6 to >=1.21.0 <=1.21.1.
- src/main/java/io/minepkg/testutils/RuleBookGUI.java
- Replaced
new IdentifierwithIdentifier.ofVanillafor SNOW_GRASS (line 29). - Replaced
new IdentifierwithIdentifier.ofVanillafor NORMAL_GRASS (line 30). - Replaced
new IdentifierwithIdentifier.ofVanillafor rain (line 37). - Replaced
new IdentifierwithIdentifier.ofVanillafor snow (line 38).
- Replaced
- src/main/java/io/minepkg/testutils/TestUtils.java
- Replaced
new IdentifierwithIdentifier.ofin theidmethod (line 38).
- Replaced
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
Minecraft's initial release was on May 17, 2009, and it was fully released on November 18, 2011.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Minecraft version from 1.20.6 to 1.21.1 in the project's configuration files and code. The changes include updating dependencies, Minecraft version references, and using the Identifier.ofVanilla method for specifying resource locations. Overall, the changes seem straightforward and necessary for keeping the project up-to-date.
Merge Readiness
The pull request appears to be a straightforward update to the Minecraft version and related dependencies. Given the nature of the changes, it's important to ensure that all dependencies and configurations are correctly updated and that the code changes are functioning as expected. I am unable to directly approve the pull request, and users should have others review and approve this code before merging. Since there are no critical or high severity issues, the pull request is likely ready to be merged once the medium severity issue is addressed.
new Identifier->Identifier.of(orofVanilla)That's it, that's the whole PR.