chore: add accessibility annotations to sharing card views#2
Merged
minghinmatthewlam merged 1 commit intomainfrom Mar 9, 2026
Merged
chore: add accessibility annotations to sharing card views#2minghinmatthewlam merged 1 commit intomainfrom
minghinmatthewlam merged 1 commit intomainfrom
Conversation
Mark the decorative flame icon as accessibilityHidden and combine child elements on both share card outer containers for VoiceOver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreakShareCardViewas.accessibilityHidden(true).accessibilityElement(children: .combine)to outer containers in bothStreakShareCardViewandYearProgressShareCardViewso VoiceOver combines all child text into a single elementShareItem.swiftreviewed — model-only file, no changes neededNote: These views are rendered to
UIImageviaImageRendererfor sharing and are never directly in the interactive UI hierarchy. Annotations added for completeness and best practice.Test plan