chore: add accessibility to UI components#4
Merged
minghinmatthewlam merged 1 commit intomainfrom Mar 9, 2026
Merged
Conversation
Add VoiceOver support to FocusChecklistRow, FocusTagPickerView, and ProgressRing. Decorative SF Symbol icons are hidden from assistive technology, interactive elements have labels/hints, and the progress ring exposes its value as a percentage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.accessibilityHidden(true)to decorative SF Symbol icons (checkmark inFocusChecklistRow, chevron inFocusTagPickerView).accessibilityElement(children: .combine)and.accessibilityLabeltoFocusChecklistRowso VoiceOver reads title and completion state as one element.accessibilityLabeland.accessibilityHintto theMenuinFocusTagPickerView.accessibilityElement(children: .ignore),.accessibilityLabel, and.accessibilityValuetoProgressRingso VoiceOver announces progress percentagePrimaryButtonStyle,FocusCardButtonStyle, andShareSheet— no changes needed (ButtonStyles have no SF Symbols; ShareSheet is a UIKit wrapper)Test plan