chore: add accessibility annotations to Home views#5
Merged
minghinmatthewlam merged 2 commits intomainfrom Mar 9, 2026
Merged
Conversation
Add VoiceOver support to all interactive elements in the Home feature: - Settings gear, year progress tile, details button, yesterday toggles - Focus completion checkboxes (inline edit + yesterday section) - Day detail navigation (close, previous day, next day) - Weekly progress day columns with combined accessibility elements - Swipe-to-delete accessible action and hidden trash icon - Decorative icons hidden (flame, calendar, chevron, checkmark/xmark) - Share button hint on streak card
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.accessibilityLabel()and.accessibilityHint()to all interactive elements (buttons, toggles) in the Home feature.accessibilityHidden(true)to decorative SF Symbol icons (flame, calendar, chevron, checkmark/xmark).accessibilityElement(children: .combine)with descriptive labels to weekly progress day columns.accessibilityAction(named: "Delete")to swipe-to-delete rows for VoiceOver usersFiles changed
HomeView.swift— Settings button, year progress tile, details button, yesterday focus togglesFocusStatusCardView.swift— Flame icon hidden, share button hintFocusInlineEditRow.swift— Completion checkbox label and hintDayFocusDetailView.swift— Close, previous day, next day buttonsWeeklyProgressGridView.swift— Day column combined accessibility with status labelsSwipeToDeleteRow.swift— Trash icon hidden, accessible delete actionYearProgressPreviewTileView.swift— Calendar and chevron icons hiddenTest plan