chore: add accessibility labels to widget views#7
Merged
minghinmatthewlam merged 2 commits intomainfrom Mar 9, 2026
Merged
Conversation
Add .accessibilityLabel(), .accessibilityHidden(), .accessibilityElement(), and .accessibilityValue() to interactive and decorative elements across all widget SwiftUI views: - HomeWidgetView: streak badge (combine + label), flame icon (hidden), focus rows (combine + label), checkmark icons (hidden) - SmallHomeWidgetView: same pattern for streak badge and focus rows - LockWidgetView: gauge label/value, fallback target image label - ProgressRing: progress label and percentage value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.accessibilityHidden(true)to decorative flame icons and checkmark/circle icons across widget views.accessibilityElement(children: .combine)and.accessibilityLabel()to streak badge HStacks and focus list row HStacks so VoiceOver reads them as single, meaningful elements (e.g., "3 day streak", "Exercise, completed").accessibilityLabel()and.accessibilityValue()to the lock screen Gauge and ProgressRing for clear VoiceOver readoutFiles changed
Widgets/Views/HomeWidgetView.swift— streak badges (header + StreakBadgeView), focus list rows (FocusListView)Widgets/Views/SmallHomeWidgetView.swift— streak badge, focus list rowsWidgets/Views/LockWidgetView.swift— Gauge label/value, fallback target imageWidgets/Views/ProgressRing.swift— progress label and percentage valueTest plan