Skip to content

chore: add accessibility to onboarding views #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minghinmatthewlam merged 1 commit into from
Mar 9, 2026
Merged

chore: add accessibility to onboarding views #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions App/Features/Onboarding/OnboardingCarouselView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ struct OnboardingCarouselView: View {
.font(.tenxDisplay)
.foregroundStyle(AppColors.textPrimary)
.padding(.bottom, 12)
.accessibilityHidden(true)

Text(step.title)
.font(.tenxTitle)
Expand Down Expand Up @@ -73,11 +74,15 @@ struct OnboardingCarouselView: View {
if stepIndex < steps.count - 1 {
Image(systemName: "chevron.right")
.font(.tenxTinySemibold)
.accessibilityHidden(true)
}
}
.frame(maxWidth: .infinity)
}
.buttonStyle(PrimaryButtonStyle())
.accessibilityHint(stepIndex == steps.count - 1
? "Completes onboarding and opens the app"
: "Advances to the next onboarding step")
.padding(.horizontal, 24)
.padding(.bottom, 32)
}
Expand All @@ -92,6 +97,7 @@ struct OnboardingCarouselView: View {
onComplete()
}
.buttonStyle(GhostButtonStyle())
.accessibilityHint("Skips the remaining onboarding steps")
}
.padding(.horizontal, 24)
.padding(.top, 12)
Expand All @@ -104,6 +110,8 @@ struct OnboardingCarouselView: View {
.animation(.easeInOut(duration: 0.2), value: stepIndex)
}
}
.accessibilityElement(children: .ignore)
.accessibilityLabel("Page \(stepIndex + 1) of \(steps.count)")
}
.padding(.bottom, 12)
}
Expand Down
1 change: 1 addition & 0 deletions App/Features/Onboarding/WelcomeView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ struct WelcomeView: View {
onBegin()
}
.buttonStyle(PrimaryButtonStyle())
.accessibilityHint("Starts the onboarding experience")
.frame(maxWidth: .infinity)

Spacer()
Expand Down
Loading