Add support for namespaces (Consul Enterprise)#30
Open
vlatkoboshkoski-rldatix wants to merge 2 commits intominiclip:masterfrom
Open
Add support for namespaces (Consul Enterprise)#30vlatkoboshkoski-rldatix wants to merge 2 commits intominiclip:masterfrom
vlatkoboshkoski-rldatix wants to merge 2 commits intominiclip:masterfrom
Conversation
Author
|
Do you need any additional info from me? Probably you can not test the enterprise features. |
Contributor
|
Hi, @vlatkoboshkoski-allocate. This pull request has conflicting files, so a rebase is probably in order. Also, would it be possible for you to add some tests, for future non-regression? Thanks. |
remove namespace instructions
Author
|
I am not sure about the tests, you will need Terraform Enterprise account to test it |
Author
|
Any updates? @paulo-ferraz-oliveira |
Contributor
|
Only saw this now, sorry about that. I'm not saying I should write or do tests 😄 What I mentioned is we'd like you to add some tests (maybe mock something) so there's no future regressions against your changes. Thanks. |
paulo-ferraz-oliveira
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is implementation of the namespace feature in Consul that is available in the Enterprise version only.
https://www.consul.io/api-docs/txn#namespace
Discussed here: #27