Allow skipping TLS certificate validation#42
Open
momania wants to merge 2 commits intominiclip:masterfrom
Open
Allow skipping TLS certificate validation#42momania wants to merge 2 commits intominiclip:masterfrom
momania wants to merge 2 commits intominiclip:masterfrom
Conversation
paulo-ferraz-oliveira
changed the title
paulo-ferraz-oliveira
changed the title
Contributor
|
Could you rename the flag |
Contributor
|
Also, would it be possible for you to add a test to this, to verify no-regression? Thanks. |
momania
force-pushed
the
feature/skip-insecure
branch
from
36fbbb0 to
43bc9f7
Compare
Author
Sure, done.
How would you do this? I don't see any tests related to the Consul importer part. |
Contributor
I'll ask internally and probably somebody else will come back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes adds a
consul-insecure-skip-verifyflag so 'insecure' Consul certificate verification is skipped.