Update TypeScript guidance #1470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types are now provided by `minio-js` and should not be installed separately via `@types/minio`.
Collaborator
|
I'll actually defer the review here to one of our JS driver developers - @prakashsvmx can you confirm and approve? |
ravindk89
added
Review
prakashsvmx
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JavaScript Install instructions include a TypeScript section. I removed it entirely because types are now provided by
minio-jsand should not be installed separately via@types/minio.Happy to consider alternatives, such as keeping the section with a note like "types are now provided by the
minio-jspackage".