MaxTools by kauefelipe · Pull Request #1667 · minj/foxtrick

kauefelipe · 2020-09-16T01:02:11Z

Module to show last match U20/U21/Senior

minj · 2020-09-19T10:45:01Z

I don't really like that this module is using an external API. This is not a ML model and can be calculated internally

MaxDareDevil · 2020-09-20T12:23:25Z

I don't really like that this module is using an external API. This is not a ML model and can be calculated internally

Hi @minj.
The idea to use an API is to avoid duplicate the code for perfect age. The next U21 world cup is really complex and a given player may have two perfect age use. In the future me and @kauefelipe would like to extend the integration between Foxtrick and MaxTools always using APIs. For example allowing at match's order page review a direct result estimation using https://ht-mt.org/match/result-estimation.
We would like to extend the perfect age information adding not only "last match" but also "last complete phase" and informing the amount of training the player would accumulate less than one in real perfect age for the phase.
So if we keep only one code that will be really interesting to avoid rework. This is the reason for the API approach.

kauefelipe · 2020-09-29T17:46:53Z

Hi @minj.

Good afternoon. Did you see MaxDareDevil's justification for using an API? You could see the plugin code?
It would be nice to have a solution since the old U20 that is on foxtrick is showing the wrong dates.

MaxDareDevil · 2020-09-29T19:02:01Z

Hi, I just renamed the account name here to be the same used at HT.

minj

On the whole, OK, minor improvements necessary.

Let me know, if you will be addressing my comments yourself.

Alternatively, GitHub now has a feature to allow access for the repo owner (i.e. me) to push into a PR branch on the fork (i.e. your repo)

minj · 2020-11-08T21:29:18Z

content/foxtrick.properties

+
+# MaxTools
+module.Maxtools.desc=Show last match U20/U21/Senior
+module.Maxtools.RomanNumberEdition.desc=Use Roman numerals in the championship edition


nit: "for the championship"

minj · 2020-11-08T21:29:43Z

content/foxtrick.properties

+module.Maxtools.desc=Show last match U20/U21/Senior
+module.Maxtools.RomanNumberEdition.desc=Use Roman numerals in the championship edition
+module.Maxtools.YouthPlayers.desc=Show last match U20/U21/Senior in the Youth Player Details page.
+module.Maxtools.SeniorPlayers.desc=Show last match U20/U21/Senior in the Senior Player Details page.


nit: "on the <...> page"

minj · 2020-11-08T21:30:37Z

content/foxtrick.properties

+# %3 = phase, e.g. CC
+# %4 = WC number, e.g. XIV
+# %5 = MaxTools.match
+MaxTools.templateShortWithoutTable=%1: %2 - %3 %4 - %5


nit: EOL missing

minj · 2020-11-08T21:33:55Z

content/information-aggregation/maxtools.js

+            //console.log('chegou aqui');
+            let lang = Foxtrick.Prefs.getString('htLanguage');
+            //let prefix = 'http://www.fantamondi.it/HTMS/index.php' +
+            //    `?page=htmspoints&lang=${lang}&action=calc`;


superfluous comments

minj · 2020-11-08T21:35:18Z

content/information-aggregation/maxtools.js

+            let lang = Foxtrick.Prefs.getString('htLanguage');
+            //let prefix = 'http://www.fantamondi.it/HTMS/index.php' +
+            //    `?page=htmspoints&lang=${lang}&action=calc`;
+            let prefix = 'https://ht-mt.org/nt/perfect-age';


use HTMT_PATH

minj · 2020-11-08T21:40:11Z

content/information-aggregation/maxtools.js

+        else if (isPlayersPage || isYouthPlayersPage)
+            module.runPlayerList(doc);
+        else if (isTransferResultsPage)
+            module.runTransferList(doc);


method missing

minj · 2020-11-08T21:41:04Z

content/information-aggregation/maxtools.js

+                container.appendChild(getLink(player.age.years, player.age.days));
+                container.appendChild(doc.createTextNode(' '));
+
+                champsList.forEach(function (championship) {


this block also repeats itself => extract and reuse

minj · 2020-11-08T21:42:28Z

content/preferences.html

 	<script type="application/x-javascript" src="./shortcuts-and-tweaks/transfer-search-filters.js"></script>
 	<script type="application/x-javascript" src="./shortcuts-and-tweaks/transfer-search-result-filters.js"></script>
 	<!-- end categorized modules -->
-


this file (and others) should not be edited manually, we have module-update.py for it

minj · 2020-11-08T21:42:51Z

defaults/preferences/foxtrick.js

 pref("extensions.foxtrick.prefs.module.MatchWeather.Irl.enabled", true);
+pref("extensions.foxtrick.prefs.module.Maxtools.enabled", true);
+pref("extensions.foxtrick.prefs.module.Maxtools.RomanNumberEdition.enabled", true);
+pref("extensions.foxtrick.prefs.module.Maxtools.YouthPlayers.enabled", true);


valid-ids should also be updated, for now

minj · 2020-11-08T21:43:47Z

manifest.json

 		"http://www.fantamondi.it/*",
-		"http://pastebin.com/api/*"
+		"http://pastebin.com/api/*",
+		"https://ht-mt.org/*"


have you considered using CORS headers instead?

minj · 2020-11-08T21:46:24Z

Apologies for the delay. I was not in a good place mentally for weeks.

MaxDareDevil · 2020-11-10T12:33:19Z

Apologies for the delay. I was not in a good place mentally for weeks.
Please do not worry about that. I'm in hurry with RL issues as well. I will talk with @kauefelipe asap.

minj · 2020-11-10T17:23:02Z

You could see the plugin code?

@kauefelipe I am not exactly sure, what you've meant here.

Btw, I'll ask for a CHPP feature to confirm this integration

minj · 2020-11-29T15:08:44Z

Are you still interested in working on this?

I would specifically like to see these:

CORS headers
Link to Data/Privacy policy

kauefelipe · 2020-11-30T01:12:57Z

Hello minj. I was on vacation last month and I couldn't get anything because I spent a lot of time traveling. I will try to make adjustments in the next few days.

kauefelipe · 2020-11-30T03:22:44Z

@minj , I made some of the adjustments you asked for.

I'm new to Git and I'm still learning. I gave you permission in my repository if you want to make any adjustments directly.

minj · 2020-11-30T22:48:58Z

Alright I hope to look at it this week but I can't make promises

kauefelipe added 5 commits July 2, 2020 02:27

MaxTools (Module to show last match U20/U21/Senior)

74c7009

MaxTools (Module to show last match U20/U21/Senior)

08d1cf9

MaxTools (Module to show last match U20/U21/Senior)

2bc5370

Merge remote-tracking branch 'upstream/master'

01224da

MaxTools (Module to show last match U20/U21/Senior)

56dcc7d

minj requested changes Nov 8, 2020

View reviewed changes

minj added chpp-needed pr labels Nov 10, 2020

minj added chpp-granted and removed chpp-needed labels Nov 21, 2020

fixing pull request issues

d3d66fa

Merge from minj:master

4901be9

Conversation

kauefelipe commented Sep 16, 2020

Uh oh!

minj commented Sep 19, 2020

Uh oh!

MaxDareDevil commented Sep 20, 2020

Uh oh!

kauefelipe commented Sep 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MaxDareDevil commented Sep 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

minj left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

minj commented Nov 8, 2020

Uh oh!

MaxDareDevil commented Nov 10, 2020

Uh oh!

minj commented Nov 10, 2020

Uh oh!

minj commented Nov 29, 2020

Uh oh!

kauefelipe commented Nov 30, 2020

Uh oh!

kauefelipe commented Nov 30, 2020

Uh oh!

minj commented Nov 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kauefelipe commented Sep 29, 2020 •

edited

Loading

MaxDareDevil commented Sep 29, 2020 •

edited

Loading