Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for JsonWebKey sets and enhances testing for JSON Web Signature functionality. Key changes include:
- Addition of new tests and functions to construct, sign, and verify using JsonWebKey sets.
- New methods in the JWS and JWK modules to work with multiple signers and verifiers via JsonWebKeySet.
- Updates to documentation and Cargo.toml to include the "crypto-rustcrypto" feature.
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/jws.rs | Added a new test case for signing JWS with JsonWebKey sets. |
| tests/jwk.rs | Introduced a new module to test the construction and retrieval of JsonWebKey sets. |
| src/jws/verify.rs | Added a new convenience method (verify_many_type) with enhanced documentation. |
| src/jws.rs | Added a new method (sign_many_type) for signing with multiple signers. |
| src/jwk/set.rs | New module providing the implementation for JsonWebKeySet management. |
| src/jwk.rs | Re-exported the new JsonWebKeySet for public consumption. |
| Cargo.toml | Updated default features to include "crypto-rustcrypto". |
Files not reviewed (2)
- .nlsp-settings/rust_analyzer.json: Language not supported
- tests/keys/set.json: Language not supported
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
3bf46a1 to
1a6df93
Compare
1a6df93 to
d24c382
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #22