Dont write in code directory #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yep - great ideas. We will merge shortly. |
Member
|
This is still outstanding and will be resolved shortly. |
I assume writing the dbname.txt file was debug that crept in by accident.
duncanparkes
force-pushed
the
dont-write-in-code-directory
branch
from
c4c4347 to
1b56293
Compare
Author
|
I've rebased this over master to save it going stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to be able to run minUP as a user which doesn't have write access to the directory with the code in (this is just good practice, and also, if it's a git checkout, it saves having to keep avoiding checking in data files).
This PR stops the dbname.txt file getting written to the code directory (I don't think this is used for anything, and doing it like it currently works stops you from running minUP as different users or running two minUP commands at once).
It also allows configuration of where the log files should go - the defaults should still be to the same place.
Cheers,
Duncan