adjust the parameters of the flippant.flip function for better control o... #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l over the back element. Changed the parameter `content` to the HTML element--that is the back of the card/modal--with the name `back`. The older way was flawed in the sense that, when the `back` element was created, it was being appended to the `body` hence reducing the control over the flippand. To better understand this, imagine a scenario where the developer wants to destroy the flipped card (i.e. the `back` element) when the user requests a new view (the Backbone-way). With the older way, it was incredibly hard to destroy the back element. If the developer specifies the `back` element by himself (as this commit allows), s/he can destroy the container of the card/modals and will simply get rid of the overflowing back element whenever a new view is created. Just a suggestion ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ver the back element.
Changed the parameter
contentto the HTML element--that is the back of the card/modal--with the nameback.The older way was flawed in the sense that, when the
backelement was created, it was being appended to thebodyhence reducing the control over the flippand.To better understand this, imagine a scenario where the developer wants to destroy the flipped card (i.e. the
backelement) when the user requests a new view (the Backbone-way). With the older way, it was incredibly hard to destroy the back element.If the developer specifies the
backelement by himself (as this commit allows), s/he can destroy the container of the card/modals and will simply get rid of the overflowing back element whenever a new view is created.Just a suggestion ;)