patch- decouple svg.js from app.js and have it as a separate file#45
Open
dkdrk wants to merge 1 commit intominutebase:masterfrom
Open
patch- decouple svg.js from app.js and have it as a separate file#45dkdrk wants to merge 1 commit intominutebase:masterfrom
dkdrk wants to merge 1 commit intominutebase:masterfrom
Conversation
Member
|
👍 I like the direction this is going. Would be great if it didn't use the Maybe should just be a global constant like Eg similar pattern to shims like: (function() {
function svgModule() {
'use strict';
const SVGS = {} // the SVG data
return { 'default': SVGS };
}
define('svgs', [], svgModule);
})(); |
Collaborator
|
Referencing buschtoens/broccoli-flatiron#1 |
4320399 to
dd64bba
Compare
db81d2e to
ae513e7
Compare
Author
|
any other changes to be done @rlivsey ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.