-
Notifications
You must be signed in to change notification settings - Fork 23
[WIP] Do not output synthetic gray/silence frames at begin/end #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
With option for same as before: by default: Note that |
|
Currently this isn't ignoring the gray frames at the end? I'm attaching a complete capture with the 20221014 build. grey-at-end.dv.dvrescue.xml.zip Also here's a sample from @iamdamosuzuki which has the same issue (not sure if it's from an HVR-M15u or recorded into the tape). |
|
Hey @JeromeMartinez, am testing this again as it stalls the #595 pr. When the deck is stopped and I run Thus I add however in this output there are gray frames at the beginning and the end. You mentioned When I test again |
|
I have made a mistake with the command line, use
content at the end of grey-at-end.dv is not considered as "nodata" because audio content is between -6 and 2, and I exclude if only between -2 and 1, should I expand the test to e.g. -8 to 8?
concealed and gray are with different option, so With |
|
@JeromeMartinez, can you rebase on main and send a new snapshot? |
Some decks sends synthetic gray/silence frames, we try to detect and discard them by default
4421497 to
7be05e2
Compare
Fix #603.
Needs MediaArea/MediaInfoLib#1606.