Enhance File Management in store_dft_output#433
Open
ShuaishuaiYuan wants to merge 2 commits intomir-group:masterfrom
Open
Enhance File Management in store_dft_output#433ShuaishuaiYuan wants to merge 2 commits intomir-group:masterfrom
ShuaishuaiYuan wants to merge 2 commits intomir-group:masterfrom
Conversation
…for curr_step, and improved comments for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
store_dft_outputfunctionality to enhance DFT output data storage and file handling logic by replacing the timestamp-based naming logic with a simpler and more consistent folder naming scheme using self.curr_step:os.makedirs(dest, exist_ok=True)to ensure the destination directory exists before processing files.self.curr_stepto organize output files by step.