Add -DWITH_PYTHON=ON to setup.py for compatibility#2
Open
olsen232 wants to merge 1 commit intomira:masterfrom
Open
Add -DWITH_PYTHON=ON to setup.py for compatibility#2olsen232 wants to merge 1 commit intomira:masterfrom
olsen232 wants to merge 1 commit intomira:masterfrom
Conversation
Compatible with google/s2-geometry as of 2021-05-07, that is commit, efb124d8eaf3433323d3e877dedd5e94a63339a3 which only builds the python bindings if WITH_PYTHON=ON.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make setup.py compatible with google/s2-geometry as of 2021-05-07
That is, commit efb124d8eaf3433323d3e877dedd5e94a63339a3 which only builds the python bindings if WITH_PYTHON=ON.