Support use on systems enforcing FIPS compliance. #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add usedforsecurity parameter to allow md5 use on systems enforcing compliance with Federal Information Processing Standards (FIPS).
The Federal Information Processing Standards (FIPS) do not allow using the md5 algorithm for encryption since it is considered too weak. The hashlib implementation of md5 provided a workaround permitting continued use of the fast md5 algorithm by explicitly noting the use was not for security purposes. The changes here try using that workaround, and fall back to failing on systems enforcing FIPS.
greyli
requested changes
Jul 13, 2025
| @@ -0,0 +1,4 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
Please remove this unrelated file.
| # succeed on systems that enforce compliance with the | ||
| # Federal Information Processing Standard (FIPS) and thus | ||
| # don't allow md5 for encryption. | ||
| md5_constructor = partial(hashlib.md5,usedforsecurity=False) |
Collaborator
There was a problem hiding this comment.
Suggested change
| md5_constructor = partial(hashlib.md5,usedforsecurity=False) | |
| md5_constructor = partial(hashlib.md5, usedforsecurity=False) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Federal Information Processing Standards (FIPS) do not allow using the md5 algorithm for encryption since it is considered too weak. The hashlib implementation of md5 provided a workaround permitting continued use of the fast md5 algorithm by explicitly noting the use was not for security purposes. The changes here try using that workaround, and fall back to failing on systems enforcing FIPS.