Skip to content
This repository was archived by the owner on Jul 14, 2021. It is now read-only.

Conversation

@miraculixx
Copy link
Owner

@miraculixx miraculixx commented Aug 26, 2016

  • without --allow-external, --process-dependency-links wouldn't find github-hosted packages
  • if requirements.local is processed first there can be conflicts in overriding or providing a dependency in requirements.extra *)
  • deduplicate the code around installing requirements.local or requirements.local.$APP

*) Rationale: e.g. a package in requirements.local requests "abc>=1.0.3" and fetches abc==2.0, however requirements.extra specifies abc==1.2, at the time requirements.extra is processed it would ignore abc==1.2. a similar case ensues when requirements.local requests a package that itself does not know to fetch in the particular version it requests, e.g. because the dependency link is wrong, where however a requirements.extra installation is provided

@miraculixx
Copy link
Owner Author

@gaumire please review - any red flags with these changes? thx.

@gaumire
Copy link
Collaborator

gaumire commented Aug 28, 2016

looks good, hoping you've tested it.

@gaumire
Copy link
Collaborator

gaumire commented Aug 29, 2016

@miraculixx would like to request to also remove these lines in this PR. Duplication.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants