NS-free regex pattern-finding implementation#7
Open
photovirus wants to merge 1 commit intomiroslavkovac:masterfrom
Open
NS-free regex pattern-finding implementation#7photovirus wants to merge 1 commit intomiroslavkovac:masterfrom
photovirus wants to merge 1 commit intomiroslavkovac:masterfrom
Conversation
9687b2e to
cfe5504
Compare
Author
|
Another option I considered is I tried it in photovirus:regex-interpolator. That one is literally 5 lines of code. |
Owner
|
@photovirus did you try doing some benchmarking before/after? I am curious what is the impact on the performance. |
Author
Nope, I couldn't. Unfortunately, I couldn't compile my code on Linux, which is why I forked the repository |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NSRegularExpressiondoesn't exist in Apple's Foundation linux port. This branch uses a recursive parser based on FoundationString.range()method to process regex.