rebase #7
Draft
rebase #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced by mistake in the previous commit:
./multipart.go:103:3: h declared and not used
The GitHub UI already displays that information.
As-is, extending PartHeader is a breaking change, and we only want to allow two variants.
Allows future extensibility.
Without the recent change of line wrapper implementation, this test is
failing. There seem to be line breaks inserted in the middle of the
body:
```diff
--- /tmp/go-message-orig-194495186.txt
+++ /tmp/go-message-after-83245617.txt
@@ -37,7 +37,8 @@
if c.editor == nil {
return
}
-@@ -1205,7 +1213,7 @@ func (c *Composer) termClosed(err error) {
+@@ -1205,7 +1
+213,7 @@ func (c *Composer) termClosed(err error) {
PushError("Failed to reopen email file: " + e.Error())
}
editor := c.editor
@@ -70,7 +71,8 @@
+ PushError(err.Error())
+ })
}
- return
+ return
+
}
--
2.47.1
```
References: c2ff70fd20da09d40ba
References: 6a718fa6214f9f35d33
Signed-off-by: Robin Jarry <robin@jarry.cc>
The doc incorrectly stated that the method requires the argument to have a comma character. Instead, it requires a colon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduces internal wrapping and refines header APIs; removes a dependency and adds tests.
go-textwrapperwith customlineWrapperinencoding.goforbase64and7bit/8bitline folding; update tests (encoding_test.go) and add comprehensivelineWrappercasesEntity.WriteToto close writer only after successful body write and propagate errorsmessage.HeaderFields,mail.PartHeader, andtextproto.HeaderFields; implement inmail/InlineHeaderandmail/AttachmentHeaderHeader.Date()returns zero time if missing;SetDate/SetMessageIDdelete field when zero/empty; minorMessage-IDparse flow fixx-utf_8j→ UTF-8AddRawdoc (colon), minor comment formattingwriter_test.go)alpine/latest, addgofmttask; update README badge to pkg.go.dev; removego-textwrapperand bumpgolang.org/x/texttov0.14.0Written by Cursor Bugbot for commit b9039e0. This will update automatically on new commits. Configure here.