Skip to content

fix(types): align ty suppressions for GraphQL and optional imports #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DamianCzajkowski merged 4 commits into from
Apr 14, 2026
Merged

fix(types): align ty suppressions for GraphQL and optional imports #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4359c2
fix(types): align ty suppressions for GraphQL and optional imports
DamianCzajkowski Apr 14, 2026
003c4ce
fix(types): align ty with ignore
DamianCzajkowski Apr 14, 2026
8a7c8aa
fix(types): align ty with ignore
DamianCzajkowski Apr 14, 2026
6444864
fix(types): align ty suppressions for GraphQL and optional imports
DamianCzajkowski Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ariadne_codegen/client_generators/dependencies/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
12 changes: 6 additions & 6 deletions ariadne_codegen/client_generators/dependencies/async_base_client_open_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand All @@ -62,9 +62,9 @@ def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
set_span_in_context,
)
except ImportError:
Context = Any # type: ignore[misc,assignment,unused-ignore]
Span = Any # type: ignore[misc,assignment,unused-ignore]
Tracer = Any # type: ignore[misc,assignment,unused-ignore]
Context = Any # ty: ignore[invalid-assignment]
Span = Any # ty: ignore[invalid-assignment]
Tracer = Any # ty: ignore[invalid-assignment]

def get_tracer(*args, **kwargs) -> Tracer: # type: ignore
raise NotImplementedError("Telemetry requires 'opentelemetry-api' package.")
Expand Down
6 changes: 3 additions & 3 deletions ariadne_codegen/client_generators/dependencies/base_client_open_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
set_span_in_context,
)
except ImportError:
Context = Any # type: ignore[misc,assignment,unused-ignore]
Span = Any # type: ignore[misc,assignment,unused-ignore]
Tracer = Any # type: ignore[misc,assignment,unused-ignore]
Context = Any # ty: ignore[invalid-assignment]
Span = Any # ty: ignore[invalid-assignment]
Tracer = Any # ty: ignore[invalid-assignment]

def get_tracer(*args, **kwargs) -> Tracer: # type: ignore
raise NotImplementedError("Telemetry requires 'opentelemetry-api' package.")
Expand Down
6 changes: 5 additions & 1 deletion ariadne_codegen/client_generators/result_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,11 @@ def _get_field_from_schema(self, type_name: str, field_name: str) -> GraphQLFiel
]
except KeyError as exc:
if field_name == TYPENAME_FIELD_NAME:
return GraphQLField(type_=GraphQLNonNull(type_=GraphQLString))
return GraphQLField(
type_=GraphQLNonNull(
type_=GraphQLString, # ty: ignore[invalid-argument-type]
),
)
raise ParsingError(
f"Field {field_name} not found in type {type_name}."
) from exc
Expand Down
8 changes: 6 additions & 2 deletions ariadne_codegen/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,12 @@ def add_mixin_directive_to_schema(schema: GraphQLSchema) -> GraphQLSchema:
name=MIXIN_NAME,
locations=[DirectiveLocation.FIELD, DirectiveLocation.FRAGMENT_DEFINITION],
args={
MIXIN_IMPORT_NAME: GraphQLArgument(type_=GraphQLString),
MIXIN_FROM_NAME: GraphQLArgument(type_=GraphQLString),
MIXIN_IMPORT_NAME: GraphQLArgument(
type_=GraphQLString, # ty: ignore[invalid-argument-type]
),
MIXIN_FROM_NAME: GraphQLArgument(
type_=GraphQLString, # ty: ignore[invalid-argument-type]
),
},
is_repeatable=True,
),
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/client_forward_refs/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/client_forward_refs_shorter_results/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/custom_config_file/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/custom_files_names/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/custom_query_builder/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/custom_scalars/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/example/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/extended_models/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/fragments_on_abstract_types/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/inline_fragments/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/interface_as_fragment/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/multiple_fragments/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/only_used_inputs_and_enums/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/operations/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/remote_schema/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/clients/shorter_results/expected_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
6 changes: 3 additions & 3 deletions tests/main/custom_operation_builder/graphql_client/async_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ async def ws_connect(*args, **kwargs):
raise NotImplementedError("Subscriptions require 'websockets' package.")
yield

ClientConnection = Any # type: ignore[misc,assignment,unused-ignore]
Data = Any # type: ignore[misc,assignment,unused-ignore]
Origin = Any # type: ignore[misc,assignment,unused-ignore]
ClientConnection = Any # ty: ignore[invalid-assignment]
Data = Any # ty: ignore[invalid-assignment]
Origin = Any # ty: ignore[invalid-assignment]

def Subprotocol(*args, **kwargs): # type: ignore # noqa: N802, N803
raise NotImplementedError("Subscriptions require 'websockets' package.")
Expand Down
Loading
Loading