Conversation
dirtymew
approved these changes
Jun 7, 2025
dirtymew
left a comment
dirtymew
left a comment
There was a problem hiding this comment.
Привет Владимир
критичных замечаний нет - работа принята
| func (ds *DaySteps) Parse(datastring string) error { | ||
| parts := strings.Split(datastring, ",") | ||
| if len(parts) != 2 { | ||
| return errors.New("некорректный формат строки для DaySteps") |
There was a problem hiding this comment.
ошибки на английском лучше - если явно не требуется другого
| // RunningSpentCalories считает потраченные калории при беге. | ||
| func RunningSpentCalories(steps int, weight, height float64, duration time.Duration) (float64, error) { | ||
| if steps <= 0 || weight <= 0 || height <= 0 || duration <= 0 { | ||
| return 0, errors.New("некорректные параметры для расчёта калорий при беге") |
There was a problem hiding this comment.
ошибка не информативная - не понятно что конкретно не так
| var err error | ||
|
|
||
| switch strings.ToLower(t.TrainingType) { | ||
| case "бег", "run", "running": |
| "Тип тренировки: Бег\nДлительность: %.2f ч.\nДистанция: %.2f км.\nСкорость: %.2f км/ч\nСожгли калорий: %.2f\n", | ||
| t.Duration.Hours(), distance, speed, calories, | ||
| ), nil | ||
| case "ходьба", "walk", "walking": |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.