-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Implement reserves and encodes subcommands #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| createCmd.Flags().StringVar(&encodeParentDir, "encode-parent-directory", "", "Encode parent directory") | ||
| createCmd.Flags().StringVar(&encodeDir, "encode-directory", "", "Encode directory") | ||
| createCmd.Flags().BoolVar(&removeOriginal, "remove-original", false, "Remove original file after encoding") | ||
| createCmd.MarkFlagRequired("recorded-id") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
Error return value of createCmd.MarkFlagRequired is not checked (errcheck)
| createCmd.Flags().StringVar(&encodeDir, "encode-directory", "", "Encode directory") | ||
| createCmd.Flags().BoolVar(&removeOriginal, "remove-original", false, "Remove original file after encoding") | ||
| createCmd.MarkFlagRequired("recorded-id") | ||
| createCmd.MarkFlagRequired("encode-mode") // Make encode-mode required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
Error return value of createCmd.MarkFlagRequired is not checked (errcheck)
| createCmd.Flags().StringVar(&encodeParentDir, "encode-parent-directory", "", "Encode parent directory") | ||
| createCmd.Flags().StringVar(&encodeDir, "encode-directory", "", "Encode directory") | ||
| createCmd.Flags().BoolVar(&allowEndLack, "allow-end-lack", false, "Allow recording to end early") | ||
| createCmd.MarkFlagRequired("program-id") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
Error return value of createCmd.MarkFlagRequired is not checked (errcheck)
| offset int | ||
| limit int | ||
| isEncoding bool | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
File is not properly formatted (gofmt)
| channel int | ||
| status string | ||
| keyword string | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
File is not properly formatted (gofmt)
| ) | ||
|
|
||
| var ( | ||
| offset int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
var offset is unused (unused)
|
|
||
| var ( | ||
| offset int | ||
| limit int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
var limit is unused (unused)
| var ( | ||
| offset int | ||
| limit int | ||
| isEncoding bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
var isEncoding is unused (unused)
This commit introduces the and subcommands to the CLI tool. Key changes include: - Implementation of , , , , and commands. - Implementation of , , and commands. - Updates to the API client wrapper () to support new API calls. - Refinements to output formatting functions in . - Addressing compilation errors and ensuring a successful build. Note: Creating reserves by program ID is not directly supported by the EPGStation API for manual reserves; they are created with encode options.
3d46c1d to
6f982e1
Compare
feat: Implement reserves and encodes subcommands
This commit introduces the and subcommands to the CLI tool.
Key changes include:
Note: Creating reserves by program ID is not directly supported by the EPGStation API for manual reserves; they are created with encode options.