-
Notifications
You must be signed in to change notification settings - Fork 0
feat(commands): implement reserves and encodes subcommands #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add comprehensive reservation and encoding management functionality: - feat(reserves): implement complete reservation management - List reservations with filtering by type, rule ID, pagination - Show detailed reservation information - Create, update, and delete reservations - Handle reservation conflicts, skips, and overlaps - Display reservation status summaries and counts - Trigger reservation system updates - feat(encodes): implement encoding job management - List running and queued encoding jobs with progress - Add new manual encoding jobs for recorded content - Cancel active or queued encoding jobs - Show encoding system status - feat(client): extend wrapper with reserves and encodes API methods - Add comprehensive wrapper methods for all reserves endpoints - Add encoding job management methods - Maintain consistent error handling and response processing - docs(readme): update documentation with new commands - Add reservation and encoding management feature descriptions - Include comprehensive usage examples for all subcommands - Update project structure documentation All commands follow existing CLI patterns and support both table and JSON output formats.
| addCmd.Flags().BoolVar(&saveSameDirectory, "save-same-dir", false, "Save in same directory as original") | ||
|
|
||
| // Mark required flags | ||
| addCmd.MarkFlagRequired("recorded-id") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
Error return value of addCmd.MarkFlagRequired is not checked (errcheck)
|
|
||
| // Mark required flags | ||
| addCmd.MarkFlagRequired("recorded-id") | ||
| addCmd.MarkFlagRequired("mode") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
Error return value of addCmd.MarkFlagRequired is not checked (errcheck)
|
|
||
| var formatter output.Formatter | ||
| switch cfg.Output.Format { | ||
| case "json": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
string json has 3 occurrences, make it a constant (goconst)
|
|
||
| var formatter output.Formatter | ||
| switch cfg.Output.Format { | ||
| case "json": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
string json has 4 occurrences, make it a constant (goconst)
Summary
This PR implements comprehensive reserves and encodes subcommand functionality for epgstationctl, providing full access to EPGStation's reservation management and encoding operations through the command line interface.
✅ Reserves Command (
epgstationctl reserves)✅ Encodes Command (
epgstationctl encodes)🔧 Technical Implementation
📚 Documentation
Test plan
Related Tasks
Implements the complete reserves and encodes functionality as requested, providing:
Other
This implementation provides the foundation for complete EPGStation management through the CLI, significantly expanding the tool's capabilities beyond the existing channels, programs, recordings, and rules commands.