Normalizing GamePath (treating as a file)#85
Open
Eliandro4 wants to merge 1 commit intomisternebula:mainfrom
Open
Normalizing GamePath (treating as a file)#85Eliandro4 wants to merge 1 commit intomisternebula:mainfrom
Eliandro4 wants to merge 1 commit intomisternebula:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was happening:
Environment.CurrentDirectory was being set to Entry.GamePath, which may point directly to data.win instead of the game directory itself. This caused incorrect path resolution when calling:
in GetFilePrePend, Entry.GamePath was treated as a file by the use of Path.GetDirectoryName that with a directory returns the parent directory.
As a result, save files and bundled resources paths could resolve to invalid locations.
What this PR changes:
Normalize GamePath during startup by forcing it to point to the data.win file.
Replace direct usage of Entry.GamePath with GetFilePrePend in these methods:
Closes #84