A2rchi settings #410
Draft
A2rchi settings #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucalavezzo
reviewed
Jan 22, 2026
| # max_tools=3, | ||
| # ) | ||
| # return [todolist_middleware, llmtoolselector_middleware] | ||
| def _build_static_middleware(self) -> List[Callable]: |
Collaborator
There was a problem hiding this comment.
we should drop this, this wasn't working
lucalavezzo
reviewed
Jan 22, 2026
| def _filter_middleware(self, middleware: Sequence[Callable]) -> List[Callable]: | ||
| enabled = self.pipeline_config.get("middleware", {}).get("enabled") | ||
| if not enabled: | ||
| return list(middleware) |
Collaborator
There was a problem hiding this comment.
if not enabled, return empty?
lucalavezzo
reviewed
Jan 22, 2026
| config_template = self.env.get_template(BASE_CONFIG_TEMPLATE) | ||
| config_rendered = config_template.render(verbosity=context.plan.verbosity, **updated_config) | ||
| static_template = self.env.get_template(BASE_STATIC_CONFIG_TEMPLATE) | ||
| static_rendered = static_template.render(verbosity=context.plan.verbosity, **updated_config) |
Collaborator
There was a problem hiding this comment.
maybe here we should validate the options?
e.g. tools passed should be a subset of the existing ones in src/a2rchi/pipelines/tools/init.py
lucalavezzo
reviewed
Jan 22, 2026
| @@ -0,0 +1,241 @@ | |||
| name: {{ name | default("default", true) }} | |||
Collaborator
There was a problem hiding this comment.
can you delete the old basic-config.yaml ?
lucalavezzo
reviewed
Jan 22, 2026
src/utils/config_loader.py
Outdated
|
|
||
| config["_config_path"] = config_path | ||
|
|
||
| config["a2rchi"] = load_a2rchi_settings(config) |
lucalavezzo
reviewed
Jan 22, 2026
src/utils/config_loader.py
Outdated
| with open(CONFIGS_PATH+f"{name}.yaml", "r") as f: | ||
| config_path = CONFIGS_PATH + f"{name}.yaml" | ||
| with open(config_path, "r") as f: | ||
| config = yaml.load(f, Loader=yaml.FullLoader) |
Collaborator
There was a problem hiding this comment.
why are we still loading from yaml? I thought the point was to red from postgres
lucalavezzo
reviewed
Jan 22, 2026
src/utils/settings_store.py
Outdated
| TABLE_MCP_SERVER_OPTIONS = "a2rchi_mcp_server_options" | ||
|
|
||
|
|
||
| def load_a2rchi_settings(config: Dict) -> Dict: |
Collaborator
There was a problem hiding this comment.
should this replace load_config?
lucalavezzo
reviewed
Jan 22, 2026
| conn.close() | ||
|
|
||
|
|
||
| def compose_a2rchi_settings( |
Collaborator
There was a problem hiding this comment.
if the UI will modify the settings, will it go through this function? Should this perform validation too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What changed (by area)
Breaking/compat notes
settings.yaml.