Skip to content

swapped 'split' for 'explode' for php7 compatibility#35

Closed
dericcrago wants to merge 1 commit intomitcho:masterfrom
dericcrago:php7_compatibility
Closed

swapped 'split' for 'explode' for php7 compatibility#35
dericcrago wants to merge 1 commit intomitcho:masterfrom
dericcrago:php7_compatibility

Conversation

@dericcrago
Copy link
Contributor

No description provided.

@jrchamp
Copy link
Contributor

jrchamp commented May 16, 2017

#21 contains this change and more.

@dericcrago
Copy link
Contributor Author

@jrchamp - that's great, but #21 has been open for like a year now, right? For anyone looking for PHP 7 compatibility, I think swapping split for explode is the only necessary change. I don't really have a preference of how, but it'd be nice for https://wordpress.org/plugins/shibboleth/ to support PHP 7.

@jrchamp
Copy link
Contributor

jrchamp commented May 31, 2017

@dericcrago You are correct. I mentioned #21 so that anyone who arrives here might benefit from some of the other WordPress, PHP Notice and Multisite benefits present in that PR. Unfortunately, the plugin owners are not regularly responding to these requests. It would be nice to have an active maintainer added to the plugin.

@srguglielmo
Copy link

Or use a maintained plugin.

cough cough SimpleShib

(Disclaimer: I'm the author/maintainer of it)

@michaelryanmcneill
Copy link

Hello, thank you for reporting this issue. I released version 1.8 today to resolve this and other issues. I am the new maintainer of the plugin and all further work on the plugin will be done in a new GitHub repository. If you have any further issues, please don't hesitate to report them in the new repository.

@dericcrago
Copy link
Contributor Author

thanks @michaelryanmcneill

@dericcrago dericcrago closed this Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants