fix(answer): only prefer Codex/Haiku when auth is actually configured#35
Open
borisnaidis wants to merge 1 commit intomitsuhiko:mainfrom
Open
fix(answer): only prefer Codex/Haiku when auth is actually configured#35borisnaidis wants to merge 1 commit intomitsuhiko:mainfrom
borisnaidis wants to merge 1 commit intomitsuhiko:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
/answercan selectopenai-codex/gpt-5.1-codex-minioranthropic/claude-haiku-4-5even when those providers are not actually configured.selectExtractionModel()treatsmodelRegistry.getApiKeyAndHeaders(model).okas “model is available”.auth.ok === trueonly means auth resolution did not error; it does not guarantee that credentials exist./answermay choose an unconfigured preferred model instead of the current model, and extraction then fails.Root cause:
getApiKeyAndHeaders()can return{ ok: true, apiKey: undefined, headers: undefined }for an unconfigured provider.Fix:
selectExtractionModel(), requiremodelRegistry.hasConfiguredAuth(model)before considering Codex or Haiku selectable.