Correct CoreMIDI memory sizing. Fixes #358#359
Open
nightbirdsevolve wants to merge 82 commits intomixedinkey-opensource:1.8from
Open
Correct CoreMIDI memory sizing. Fixes #358#359nightbirdsevolve wants to merge 82 commits intomixedinkey-opensource:1.8from
nightbirdsevolve wants to merge 82 commits intomixedinkey-opensource:1.8from
Conversation
…rting between beats and seconds, along with tests. (cherry picked from commit 6e0c342ca02df5a61a7b15e94c6b208a29a73f24)
…Stamp to seconds to MIKMIDISequencer, plus tests. (cherry picked from commit 7d746a613a2194189dff3fe52669eaa7460b8507)
… conversion methods, along with more test coverage.
…econdsForMusicTimeStamp:options:] and add tests for it
…izers where bridged methods incorrectly took an error: Void argument. Fixes issue mixedinkey-opensource#272.
…n methods respect overridden rate (+ tests)
…r -[MIKMIDISequence tempoEvents]
…mTimeStamp:toTimeStamp:] for a ~25x speedup. Fixes mixedinkey-opensource#275.
…rting between beats and seconds, along with tests. (cherry picked from commit 6e0c342ca02df5a61a7b15e94c6b208a29a73f24)
…Stamp to seconds to MIKMIDISequencer, plus tests. (cherry picked from commit 7d746a613a2194189dff3fe52669eaa7460b8507)
… conversion methods, along with more test coverage.
…econdsForMusicTimeStamp:options:] and add tests for it
…ce/issue-273 Add rate property to MIKMIDISequencer
…ce/issue-275 Improve performance of -[MIKMIDISequence tempoEvents]
…tering in -[MIKMIDISequencer timeInSecondsForMusicTimeStamp:options:].
…ache tempo events. Speeds up getting tempo events by ~99% again.
…ce and add associated test
…s into a track, along with performance test for sequence copying and updated baselines
… creation machinery to allow specializing command subclass initialization based on MIDI packet contents, not just command type
…eCommand subclass. WIP
…achineControlCommand including tests
…etCommand a subclass of MIKMIDIMachineControlCommand
…of MIKMMCLocateTargetCommand (fka. MIKMIDIMachineControlLocateTargetCommand)
…ating MIKMMCLocateTargetCommand
…plementation to MIKMMCLocateTargetCommand
…tSourceEndpoint initWithName:error:] into Swift
…ce/issue-297-client-source-endpoint-initializer Issue mixedinkey-opensource#297: Fix weird bridging of -[MIKMIDIClientSourceEndpoint initWithName:error:] into Swift
…ARM the MIDIPackets in a MIDIPacketList are 4-byte aligned, and not packed as they are on X86/PowerPC.
… data in [MIKMIDICommand commandsWithMIDIPacket:].
This reverts commit 180e17a.
armadsen
requested changes
Apr 8, 2026
| } | ||
|
|
||
| // Bounds check | ||
| if (eventDataLength == 0 || eventDataLength > 256 || dataOffset + eventDataLength > inputPacket->length) { |
Member
There was a problem hiding this comment.
I'm a little confused about this. Why are you breaking if eventDataLength is > 256? That should be OK now that malloc is being used instead of a static sizeof(MIDIPacketList) byte stack allocation for the packet list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @armadsen . I was having crashes recently on my app 106 Editor that makes heavy SysEx usage. The same culprit kept showing in the logs, so i nailed it down, and here's the fix. If you could have a look in the following weeks, i'd be delighted! Thank you :)