Skip to content

Pass filename option to jade.compileClient#2

Open
muratayusuke wants to merge 1 commit intomizchi:masterfrom
BEST10developers:feature/filename_option
Open

Pass filename option to jade.compileClient#2
muratayusuke wants to merge 1 commit intomizchi:masterfrom
BEST10developers:feature/filename_option

Conversation

@muratayusuke
Copy link

@muratayusuke muratayusuke commented Oct 20, 2015

When I use include tag with relative path in my jade file, I got following error:

the "filename" option is required to use "include" with "relative" paths
  at Parser.resolvePath (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:465:13)
  at Parser.parseInclude (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:564:21)
  at Parser.parseExpr (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:223:21)
  at Parser.block (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:708:25)
  at Parser.tag (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:817:24)
  at Parser.parseTag (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:738:17)
  at Parser.parseExpr (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:211:21)
  at Parser.parseExpr (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:250:21)
  at Parser.block (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:708:25)
  at Parser.tag (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:817:24)
  at Parser.parseTag (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:738:17)
  at Parser.parseExpr (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:211:21)
  at Parser.parseExpr (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:250:21)
  at Parser.block (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:708:25)
  at Parser.tag (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:817:24)
  at Parser.parseTag (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:738:17)
  at Parser.parseExpr (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:211:21)
  at Parser.block (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:708:25)
  at Parser.parseEach (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:440:23)
  at Parser.parseExpr (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:233:21)
  at Parser.block (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:708:25)
  at Parser.tag (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:817:24)
  at Parser.parseTag (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:738:17)
  at Parser.parseExpr (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:211:21)
  at Parser.parseExpr (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:250:21)
  at Parser.block (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:708:25)
  at Parser.parseCode (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:361:25)
  at Parser.parseExpr (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:235:21)
  at Parser.block (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:708:25)
  at Parser.tag (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:817:24)
  at Parser.parseTag (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:738:17)
  at Parser.parseExpr (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:211:21)
  at Parser.parseExpr (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:250:21)
  at Parser.block (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:708:25)
  at Parser.tag (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:817:24)
  at Parser.parseTag (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:738:17)
  at Parser.parseExpr (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:211:21)
  at Parser.parseExpr (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:250:21)
  at Parser.parse (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/node_modules/jade/lib/parser.js:122:25)
  at parse (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/lib/parse.js:25:21)
  at Function.compileClient (/myapp/node_modules/@mizchi/gulp-react-jade/node_modules/react-jade/lib/compile-client.js:25:7)
  at DestroyableTransform._transform (/myapp/node_modules/@mizchi/gulp-react-jade/index.js:19:31)
  .
  .
  .

So I just pass this required option to jade.compileClient(). Would you confirm and merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@muratayusuke