sign-attached-block destroy prevention#2
Open
ArmEagle wants to merge 100 commits intomjmr89:masterfrom
Open
Conversation
added 30 commits
March 30, 2011 01:56
of a TradeCraft shop the player is not allowed to destroy.
If config files (.properties and .txt) do not exist, default files will be copied from the jar file. Removed several warnings (changes across a lot of files) Changed version to 0.81AE to mark it as modified Working with Bukkit#495/CB#617(RB)
using TradeCraft.canSetCurrency permission entry.
loaded (code was missing call to .load()). Currency is saving and used correctly now. All references to "gold" are replaced by the name of the current set currency. And probably some other small changes I already forgot about.
Prevented invalid object type to be set as currency (not existing name/id).
true). If true the player name on a shop sign has to match the actual player name. If set to false, the actual player's name only has to start with the name set on the sign.
is disable and then enabled. Clears some memory use on disabling. Prevents event listeners from triggering when the plugin is disabled (really need to be able to unhook listeners).
the command that lists the shops owned by the player
Fixed permissions check on placing of a sign (now using new style, lines from event).
from distance (server reverts, client will let you type text on the sign, but the sign won't be there).
check). Version updated to 0.92AE
signs with item name line "[name]" if "name" is found in the configuration file.
6:2, one could sell/buy as if it was 3:1.
data-value item in txt). Fixed some small things. Changed version to AE-1.0.0-alpha
used as lookup in a hashmap (used for plugin myShops command).
Prevent NPE when currency is not in the items file (only to override the default item name).
- Fixed bug in translation code, would still try to default to English language file
config and does not exist in there.
show-shop-location
accept and listen other plugins canceling events we're interested in.
first use there will be no issues.
…ow so on first use there will be no issues." This reverts commit a1154e4.
- Now blocks piston events if it would move a sign or the block behind it. - Two new settings "player-world-shop-limit" (default 5) and "player-total-shop-limit" (default 10) that limit the amount of shops any player can have in a world and in total. For this two translation lines were added: WORLD_SHOP_LIMIT_X and TOTAL_SHOP_LIMIT_X. These aren't automatically taken over by the existing language files!
…support for old Permissions plugin, now only supporting Bukkit's built-in system. - Cleanup up tabs for whitespaces" This reverts commit 6adf701.
…instead of RIGHT_CLICK_BLOCK. Scan ahead 2 blocks in those situations instead and try to find a block that way. Version upped to 1.4.1.
Fixed: When standing too close, a RIGHT_CLICK_AIR event can be fired instead of RIGHT_CLICK_BLOCK. Scan ahead 2 blocks in those situations instead and try to find a block that way. Version upped to 1.4.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added prevention of block removal when there's a sign attached to it
of a TradeCraft shop the player is not allowed to destroy.
This is my first time using GitHub like this. I did some basic testing but feel free to do a code review and more testing.