feat: comprehensive improvements and dev workflow enhancements #136
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,236 @@ | ||
| name: Dev Release Build | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| platform: | ||
| description: 'Target platform' | ||
| required: true | ||
| type: choice | ||
| options: | ||
| - macos | ||
| - linux | ||
| - windows | ||
| version: | ||
| description: 'Version to set (optional)' | ||
| required: false | ||
| type: string | ||
|
|
||
| jobs: | ||
| build-macos: | ||
| runs-on: macos-latest | ||
| if: ${{ inputs.platform == 'macos' }} | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@v3 | ||
| with: | ||
| version: 8 | ||
| run_install: false | ||
|
|
||
| - name: Get pnpm store directory | ||
| shell: bash | ||
| run: echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV | ||
|
|
||
| - name: Setup pnpm cache | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: ${{ env.STORE_PATH }} | ||
| key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-pnpm-store- | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
||
| - name: Set version | ||
| if: ${{ inputs.version != '' }} | ||
| shell: bash | ||
| run: | | ||
| node -e " | ||
| const fs = require('fs'); | ||
| const pkg = JSON.parse(fs.readFileSync('package.json', 'utf8')); | ||
| pkg.version = '${{ inputs.version }}'; | ||
| fs.writeFileSync('package.json', JSON.stringify(pkg, null, 2) + '\n'); | ||
| console.log(\`Version set to \${pkg.version}\`); | ||
| " | ||
|
|
||
|
Comment on lines
+54
to
+65
Contributor
There was a problem hiding this comment. 🧹 Nitpick (assertive) Add validation for version input format The version setting logic doesn't validate the format of the input version string. Consider adding validation to ensure it follows semantic versioning or your project's version format to prevent invalid versions from being set. - name: Set version
if: ${{ inputs.version != '' }}
shell: bash
run: |
node -e "
const fs = require('fs');
+ const version = '${{ inputs.version }}';
+ // Basic semver validation
+ if (!/^v?\d+\.\d+\.\d+(-[a-zA-Z0-9.-]+)?(\+[a-zA-Z0-9.-]+)?$/.test(version)) {
+ console.error('Invalid version format: ' + version);
+ process.exit(1);
+ }
const pkg = JSON.parse(fs.readFileSync('package.json', 'utf8'));
- pkg.version = '${{ inputs.version }}';
+ pkg.version = version;
fs.writeFileSync('package.json', JSON.stringify(pkg, null, 2) + '\n');
console.log(\`Version set to \${pkg.version}\`);
"Also applies to: 127-138, 200-211 🤖 Prompt for AI Agents |
||
| - name: Build macOS package | ||
| run: | | ||
| pnpm build | ||
| pnpm exec electron-builder --mac --publish never | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| ELECTRON_BUILDER_CHANNEL: dev | ||
|
|
||
| - name: List build artifacts | ||
| shell: bash | ||
| run: | | ||
| echo "Build artifacts:" | ||
| find dist -type f -name "*" | head -20 | ||
|
|
||
| - name: Upload artifacts | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: macos-dev-artifacts | ||
| path: | | ||
| dist/*.dmg | ||
| dist/*.zip | ||
| dist/*.yml | ||
| dist/*.yaml | ||
| dist/*.blockmap | ||
| retention-days: 30 | ||
| if-no-files-found: warn | ||
|
|
||
| build-linux: | ||
| runs-on: ubuntu-latest | ||
| if: ${{ inputs.platform == 'linux' }} | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@v3 | ||
| with: | ||
| version: 8 | ||
| run_install: false | ||
|
|
||
| - name: Get pnpm store directory | ||
| shell: bash | ||
| run: echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV | ||
|
|
||
| - name: Setup pnpm cache | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: ${{ env.STORE_PATH }} | ||
| key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-pnpm-store- | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
||
| - name: Set version | ||
| if: ${{ inputs.version != '' }} | ||
| shell: bash | ||
| run: | | ||
| node -e " | ||
| const fs = require('fs'); | ||
| const pkg = JSON.parse(fs.readFileSync('package.json', 'utf8')); | ||
| pkg.version = '${{ inputs.version }}'; | ||
| fs.writeFileSync('package.json', JSON.stringify(pkg, null, 2) + '\n'); | ||
| console.log(\`Version set to \${pkg.version}\`); | ||
| " | ||
|
|
||
| - name: Build Linux package | ||
| run: | | ||
| pnpm build | ||
| pnpm exec electron-builder --linux --publish never | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| ELECTRON_BUILDER_CHANNEL: dev | ||
|
|
||
| - name: List build artifacts | ||
| shell: bash | ||
| run: | | ||
| echo "Build artifacts:" | ||
| find dist -type f -name "*" | head -20 | ||
|
|
||
| - name: Upload artifacts | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: linux-dev-artifacts | ||
| path: | | ||
| dist/*.AppImage | ||
| dist/*.deb | ||
| dist/*.yml | ||
| dist/*.yaml | ||
| dist/*.blockmap | ||
| retention-days: 30 | ||
| if-no-files-found: warn | ||
|
|
||
| build-windows: | ||
| runs-on: windows-latest | ||
| if: ${{ inputs.platform == 'windows' }} | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@v3 | ||
| with: | ||
| version: 8 | ||
| run_install: false | ||
|
|
||
| - name: Get pnpm store directory | ||
| shell: bash | ||
| run: echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV | ||
|
|
||
| - name: Setup pnpm cache | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: ${{ env.STORE_PATH }} | ||
| key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-pnpm-store- | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
||
| - name: Set version | ||
| if: ${{ inputs.version != '' }} | ||
| shell: bash | ||
| run: | | ||
| node -e " | ||
| const fs = require('fs'); | ||
| const pkg = JSON.parse(fs.readFileSync('package.json', 'utf8')); | ||
| pkg.version = '${{ inputs.version }}'; | ||
| fs.writeFileSync('package.json', JSON.stringify(pkg, null, 2) + '\n'); | ||
| console.log(\`Version set to \${pkg.version}\`); | ||
| " | ||
|
|
||
| - name: Build Windows package | ||
| run: | | ||
| pnpm build | ||
| pnpm exec electron-builder --win --publish never | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| ELECTRON_BUILDER_CHANNEL: dev | ||
|
|
||
| - name: List build artifacts | ||
| shell: bash | ||
| run: | | ||
| echo "Build artifacts:" | ||
| find dist -type f -name "*" | head -20 | ||
|
|
||
| - name: Upload artifacts | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: windows-dev-artifacts | ||
| path: | | ||
| dist/*.exe | ||
| dist/*.yml | ||
| dist/*.yaml | ||
| dist/*.blockmap | ||
| retention-days: 30 | ||
| if-no-files-found: warn | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Update deprecated actions/cache to v4
The workflow uses
actions/cache@v3which is deprecated. GitHub recommends updating to v4 for continued support and security updates.Apply this update to all three occurrences (lines 44, 117, 190).
Also applies to: 117-117, 190-190
🧰 Tools
🪛 actionlint (1.7.7)
44-44: the runner of "actions/cache@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🤖 Prompt for AI Agents