Dev2alpha

[mkdir700]

Summary by CodeRabbit

• New Features

  • Click words in subtitles to open a dictionary popover with pronunciations, definitions, and translations, including audio playback. Added Chinese localization for dictionary UI.
  • Integrated error/crash monitoring to improve stability.
  • Optimized update channels with region-aware routing for users in China.

• Bug Fixes

  • Prevented crashes on environments without ResizeObserver.
  • More resilient dictionary parsing across varied formats.

• Chores

  • Added prerelease support to release sync workflow.
  • Updated update feed URLs and added Sentry dependency.

• Tests

  • Added end-to-end tests for subtitle dictionary lookup and playback behavior.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Adds Sentry error tracking (main and renderer), implements dictionary popover with pronunciation parsing and UI, updates feed selection with CN routing, adjusts workflows to include prereleases and body fetching, modifies player orchestrator by removing retry checks, updates types/i18n/tests accordingly, and tweaks docs and test utilities.

Changes

Cohort / File(s)	Summary
Release workflow updates .github/workflows/sync-release-to-gitcode.yml	Trigger includes prereleased; workflow_dispatch fetches release body when absent; no functional changes to asset steps.
Documentation update CLAUDE.md	Removes outdated guidance; adds theming fix notes for DictionaryPopover using Ant Design CSS variables.
Sentry dependencies and typings package.json, packages/shared/types/sentry.d.ts	Adds @sentry/electron dependency; introduces TS declarations for Sentry Electron main/renderer APIs and option types.
Sentry services & early init src/main/index.ts, src/main/services/SentryService.ts, src/renderer/src/init.ts, src/renderer/src/services/SentryService.ts	Adds Sentry services for main/renderer with privacy filters, logger integration, dynamic loading; early initialization in app startup paths.
Updater feed routing & constants packages/shared/config/constant.ts, src/main/services/AppUpdater.ts	Changes production feed URL; adds CN_BETA/CN_ALPHA; selects feeds by IP country (CN vs non-CN) for latest and prerelease channels.
Dictionary backend parsing src/main/services/DictionaryService.ts	Switches from single phonetic to pronunciations array; adds parsing utilities for voice params, audio URLs, and robust definition extraction.
Dictionary types & i18n src/renderer/src/infrastructure/types/dictionary.ts, src/renderer/src/i18n/locales/zh-cn.json	Adds PronunciationInfo; updates DictionaryResult to pronunciations?; adds zh-CN strings for dictionary UI.
Dictionary UI & integration src/renderer/src/pages/player/components/DictionaryPopover.tsx, src/renderer/src/pages/player/components/SubtitleContent.tsx	New popover component with playback and states; integrates per-token lookup; removes onWordClick prop; manages focus and visibility.
Subtitle overlay and surface tweaks src/renderer/src/pages/player/components/SubtitleOverlay.tsx, src/renderer/src/pages/player/components/VideoSurface.tsx	Guarded ResizeObserver usage; removes onWordClick wiring; removes surface onKeyDown.
Player shortcuts logging src/renderer/src/pages/player/hooks/usePlayerShortcuts.ts	Adds debug logging for play/pause shortcut; tweaks log message.
Playback orchestrator behavior src/renderer/src/pages/player/engine/PlayerOrchestrator.ts, src/renderer/src/pages/player/engine/__tests__/PlayerOrchestrator.playback-reliability.test.ts	Removes delayed verification/retries after play/pause; updates tests to expect single calls.
Dictionary tests src/main/__tests__/DictionaryService.test.ts, tests/SubtitleDictionaryLookup.test.tsx	Expands tests for pronunciations and parsing; adds renderer-level dictionary lookup tests with mocked UI and API.
DB DAO test stabilization src/main/db/dao/__tests__/VideoLibraryDAO.test.ts	Introduces fixed timestamps and thumbnail path for deterministic tests.
Test environment scaffolding tests/setup.ts	Mocks window.api.dictionary.queryEudic, ResizeObserver, speechSynthesis, getComputedStyle, and DOM selectors for stable tests.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Subtitle as SubtitleContent
  participant API as window.api.dictionary
  participant Popover as DictionaryPopover

  User->>Subtitle: Click word token
  Subtitle->>Popover: Open with loading
  Subtitle->>API: queryEudic(word)
  API-->>Subtitle: DictionaryResult (pronunciations, definitions, translations)
  Subtitle->>Popover: Update with data or error
  User->>Popover: Click pronunciation play
  Popover->>PopAudio: Try audioUrl
  alt audio fails
    Popover->>SpeechSynthesis: Fallback speak (uk/en-GB else en-US)
  end
  User->>Popover: Close
  Popover-->>Subtitle: onClose
  Subtitle->>UI: Restore focus

Loading

sequenceDiagram
  autonumber
  participant App as Electron Main
  participant Svc as SentryService (main)
  participant Rend as Renderer Init
  participant RSvc as SentryService (renderer)

  App->>Svc: init()
  Svc->>SentryMain: dynamic import + init(config)
  Note over Svc: Set tags/contexts, filters
  Rend->>RSvc: init()
  RSvc->>SentryRenderer: dynamic import + init(config)
  Note over RSvc: Hook logger, window error handlers

Loading

sequenceDiagram
  autonumber
  participant Updater as AppUpdater
  participant Geo as IP Country Lookup
  participant Feeds as FeedUrl

  Updater->>Geo: get ipCountry
  Geo-->>Updater: 'cn' or other
  alt Production or Latest
    alt ipCountry == 'cn'
      Updater->>Feeds: Use PRODUCTION (latest) / CN_* (prerelease)
    else non-CN
      Updater->>Feeds: Use GITHUB_LATEST or GitHub prerelease tag
    end
  end

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related PRs

• feat(telemetry): integrate Sentry error monitoring across main and renderer processes #176 — Also adds Sentry integration across main/renderer, types, and init points; overlaps files and approach.
• feat(player): comprehensive dictionary popover with pronunciation and theme support #171 — Modifies dictionary parsing, types, and UI similar to this PR’s pronunciation-centric changes.
• Dev2alpha #181 — Adjusts the release workflow and updater feed selection, including CN routing and feed constants.

Poem

A rabbit taps the keys with cheer,
Sentry awake, it lends an ear.
Words now bloom in popovers bright,
UK, US—both sound just right.
Feeds hop east when China’s near—
Play, pause, tidy code, all clear.
Thump-thump! Ship it—burrow’s here. 🐇✨

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dev2alpha

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1767260 and 19bdd26.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (24)

• .github/workflows/sync-release-to-gitcode.yml (4 hunks)
• CLAUDE.md (1 hunks)
• package.json (1 hunks)
• packages/shared/config/constant.ts (1 hunks)
• packages/shared/types/sentry.d.ts (1 hunks)
• src/main/__tests__/DictionaryService.test.ts (5 hunks)
• src/main/db/dao/__tests__/VideoLibraryDAO.test.ts (7 hunks)
• src/main/index.ts (1 hunks)
• src/main/services/AppUpdater.ts (1 hunks)
• src/main/services/DictionaryService.ts (6 hunks)
• src/main/services/SentryService.ts (1 hunks)
• src/renderer/src/i18n/locales/zh-cn.json (1 hunks)
• src/renderer/src/infrastructure/types/dictionary.ts (1 hunks)
• src/renderer/src/init.ts (1 hunks)
• src/renderer/src/pages/player/components/DictionaryPopover.tsx (1 hunks)
• src/renderer/src/pages/player/components/SubtitleContent.tsx (6 hunks)
• src/renderer/src/pages/player/components/SubtitleOverlay.tsx (1 hunks)
• src/renderer/src/pages/player/components/VideoSurface.tsx (0 hunks)
• src/renderer/src/pages/player/engine/PlayerOrchestrator.ts (0 hunks)
• src/renderer/src/pages/player/engine/__tests__/PlayerOrchestrator.playback-reliability.test.ts (2 hunks)
• src/renderer/src/pages/player/hooks/usePlayerShortcuts.ts (1 hunks)
• src/renderer/src/services/SentryService.ts (1 hunks)
• tests/SubtitleDictionaryLookup.test.tsx (1 hunks)
• tests/setup.ts (2 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}