Skip to content

Fix double mutex unlock in concurrent contract save queue #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkmccarty merged 3 commits into from
Jan 30, 2026
Merged

Fix double mutex unlock in concurrent contract save queue #2133

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11e8034
Initial plan
Copilot Jan 30, 2026
a26b90d
Fix double mutex unlock bug by using continue instead of break
Copilot Jan 30, 2026
dc5f9f5
Merge branch 'mm-branch-1' into copilot/sub-pr-2131-again
mkmccarty Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/boost/boost_datastore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ func saveData(contractHash string) {
default:
// Queue is full, skip this one (it will be retried in the next save cycle)
log.Printf("Save queue full, skipping contract: %s", contractHash)
// Do not mark as pending so it can be retried in a future save cycle
break
saveQueueMutex.Unlock()
continue
Comment on lines 116 to +119
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the default branch, log.Printf runs while saveQueueMutex is held. Logging can block (I/O) and prolong mutex hold time, which may increase contention and delay the worker’s pendingSaves cleanup under load. Consider unlocking before logging (capture contractHash first) and keeping the locked section minimal; optionally rate-limit this message to avoid log spam when the queue is full.

Copilot uses AI. Check for mistakes.
}
}
saveQueueMutex.Unlock()
Expand Down
Loading