Skip to content

fix(insight): keep the local API same-origin by default #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaun0927 wants to merge 2 commits into
base: main
Choose a base branch
from
+252 −62
Open

fix(insight): keep the local API same-origin by default #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82cb8f2
Protect Insight from same-machine cross-origin reads and deletes
shaun0927 Apr 16, 2026
fa2617b
Make the Insight CORS regression test hermetic
shaun0927 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions insight/server.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,7 @@ function serveStaticFile(pathname) {
// ── Server (dual runtime) ────────────────────────────────

const indexHTML = readFileSync(join(DIST_DIR, "index.html"), "utf8");
const API_JSON_HEADERS = { "Content-Type": "application/json" };

if (isBun) {
// Bun: use Bun.serve
Expand All @@ -597,7 +598,7 @@ if (isBun) {
const data = route(req.method, url.pathname, url.searchParams);
if (data !== null) {
return new Response(JSON.stringify(data), {
headers: { "Content-Type": "application/json", "Access-Control-Allow-Origin": "*" },
headers: API_JSON_HEADERS,
});
}
if (url.pathname.startsWith("/assets/") || url.pathname.match(/\.\w{2,4}$/)) {
Expand All @@ -613,8 +614,6 @@ if (isBun) {
// Node: use http.createServer
const server = createHttpServer((req, res) => {
const url = new URL(req.url, `http://localhost:${PORT}`);
res.setHeader("Access-Control-Allow-Origin", "*");
res.setHeader("Access-Control-Allow-Methods", "GET, DELETE, OPTIONS");
if (req.method === "OPTIONS") { res.writeHead(204); res.end(); return; }

const data = route(req.method, url.pathname, url.searchParams);
Expand Down
Loading