-
Notifications
You must be signed in to change notification settings - Fork 517
[transformers-to-mlx skill] Add OLMo Hybrid model support #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pcuenca
wants to merge
9
commits into
ml-explore:main
Choose a base branch
from
pcuenca:olmo-hybrid-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+446
−11
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d6a3190
Add OLMo Hybrid (GatedDeltaNet + Full Attention) model support
pcuenca 8e15770
Refactor ModelArgs in OlmoHybrid to use dynamic attributes and improv…
Goekdeniz-Guelmez cdac5d3
Fix RMSNormGated call method to return gate without type conversion
Goekdeniz-Guelmez 3680ba4
Add unit test for OLMo Hybrid model initialization and configuration
Goekdeniz-Guelmez 927fb06
Merge pull request #6 from Goekdeniz-Guelmez/nits-on-olmo-hybrid
pcuenca 4eac6b8
Restore NoPE behaviour.
pcuenca 9572376
Refactor and reuse precise_swiglu from Qwen 3 Next
pcuenca 7ca7d75
Remove repeat
pcuenca b0706fc
Remove unnecessary key replacements.
pcuenca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the exact same signature that appeared in the Qwen 3 Next implementation; let me know if it's preferable to rid the
h.