Fix SSM dt clamp default for Nemotron-H#1026
Merged
angeloskath merged 1 commit intoml-explore:mainfrom Mar 30, 2026
Merged
Conversation
|
Nice find — this matches the HF reference and the perplexity improvements are significant, especially on the Super 120B. I run Nemotron-3-Super-120B-A12B (5-bit) daily on M2 Ultra 128GB via the Nemotron-H implementation from PR #992. Will test this fix against my production workload and report back with before/after comparison. The original |
angeloskath
approved these changes
Mar 30, 2026
Member
angeloskath
left a comment
There was a problem hiding this comment.
Awesome! Thanks for the fix and the evals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix that removes incorrect lower bound clamping on SSM time steps for Nemotron-H, which negatively affects output quality. This also matches the HF reference. Results from tests below (4-bit versions):
seq_len=4096, 25 samples, tulu-3-sft-mixture
seq_len=4096, 25 samples, calibration_v5.txt