Stop generation on consecutive duplicate tool calls#1027
Draft
chopchop-jiahao wants to merge 2 commits intoml-explore:mainfrom
Draft
Stop generation on consecutive duplicate tool calls#1027chopchop-jiahao wants to merge 2 commits intoml-explore:mainfrom
chopchop-jiahao wants to merge 2 commits intoml-explore:mainfrom
Conversation
Models like Qwen3.5-9B generate 43-64 identical tool calls in a single response until max_tokens, wasting compute and confusing agent loops. Add ToolCallDedup: compares each completed tool call with the previous one during generation. On consecutive duplicate, stop with finish_reason=tool_calls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using tool calling with certain models (e.g. Qwen3.5-9B), the model sometimes generates 43–64 identical tool calls in a single response until
max_tokensis exhausted. This wastes compute and confuses the agent loop.This PR adds a lightweight
ToolCallDedupclass that compares each completed tool call with the previous one. On consecutive duplicate, generation stops early withfinish_reason=tool_calls.Changes:
mlx_lm/tool_call_dedup.py— simple consecutive duplicate detector (exact string comparison, no JSON normalization)server.py— one instance per request, checked at eachtool_call_endtokenDesign decisions:
Closes #613