Fix CacheDataset.itemlen returning wrong length#1029
Open
eyupcanakman wants to merge 1 commit intoml-explore:mainfrom
Open
Fix CacheDataset.itemlen returning wrong length#1029eyupcanakman wants to merge 1 commit intoml-explore:mainfrom
eyupcanakman wants to merge 1 commit intoml-explore:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #596.
CacheDataset.itemlen calls len(self._data[idx]) which returns the number of dict keys (always 1 for ChatDataset), not the actual token count. Length-based batch sorting in the trainer is effectively disabled because every item looks the same length.
Changed to len(self[idx][0]) which processes the item through the tokenizer and returns the real sequence length.