Use model's generation_config.json for default sampling parameters#1031
Open
eyupcanakman wants to merge 1 commit intoml-explore:mainfrom
Open
Use model's generation_config.json for default sampling parameters#1031eyupcanakman wants to merge 1 commit intoml-explore:mainfrom
eyupcanakman wants to merge 1 commit intoml-explore:mainfrom
Conversation
|
The three-tier priority (per-request > generation_config.json > hardcoded defaults) and the lazy |
Models like Phi-4 ship a generation_config.json with sampling defaults (temperature, top_p, etc.) but mlx-lm only read eos_token_id from it. Now generate, chat, and server read these values and use them when the user does not specify an explicit override. The priority chain is: user CLI arg > generation_config.json > hardcoded default. The server resolves defaults lazily per request so model hot-swapping picks up the new model's config correctly. Also adds --min-p and --top-k CLI args to chat.py (already present in generate.py) so generation_config values for those keys are not silently ignored. Fixes ml-explore#140
a23f530 to
f9bbfe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140.
Models like Phi-4 ship a generation_config.json with sampling defaults (temperature, top_p, etc.) but mlx-lm only read eos_token_id from it. Now generate, chat, and server read these values and use them when the user does not specify an explicit override.
The priority chain is: user CLI arg > generation_config.json > hardcoded default.
The server resolves defaults lazily per request so model hot-swapping picks up the new model's config correctly.
Also adds --min-p and --top-k CLI args to chat.py (already present in generate.py) so generation_config values for those keys are not silently ignored.