Skip to content

skip xtc sampling when threshold is zero#1040

Draft
mm65x wants to merge 1 commit intoml-explore:mainfrom
mm65x:fix-xtc-threshold-default
Draft

skip xtc sampling when threshold is zero#1040
mm65x wants to merge 1 commit intoml-explore:mainfrom
mm65x:fix-xtc-threshold-default

Conversation

@mm65x
Copy link
Copy Markdown
Contributor

@mm65x mm65x commented Mar 22, 2026

fixes #1036.

make_sampler() activates XTC when xtc_probability > 0.0 but doesn't
check xtc_threshold. with the default threshold=0.0, all softmax
probabilities pass the threshold, so apply_xtc() masks everything
except the least probable token.

added xtc_threshold > 0.0 to the activation gate so threshold zero
disables XTC, consistent with how probability zero already does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XTC threshold=0.0 default causes destructive sampling

1 participant