Merged
Conversation
awni
force-pushed
the
fix_release
branch
2 times, most recently
from
f508909 to
134af5b
Compare
madrob
reviewed
Nov 14, 2025
| - uses: ./.github/actions/setup-macos | ||
| - uses: ./.github/actions/build-macos | ||
| with: | ||
| macos-target: ${{ matrix.macos-target }} |
Contributor
There was a problem hiding this comment.
Is this more useful than setting an env for the entire step?
Member
Author
There was a problem hiding this comment.
By no means, I'd rather set it for the full step, just didn't know it was possible.
| run: | | ||
| uv run --no-project setup.py clean --all | ||
| MLX_BUILD_STAGE=2 uv run -m build -w | ||
| conda activate env |
Contributor
There was a problem hiding this comment.
Conda needs to be set up for nightlies as well
| @@ -54,6 +55,7 @@ jobs: | |||
| runs-on: ${{ matrix.runner }} | |||
| env: | |||
| PYPI_RELEASE: 1 | |||
Contributor
There was a problem hiding this comment.
Dos this need to be the opposite of DEV_RELEASE?
Member
Author
There was a problem hiding this comment.
No, PYPI_RELEASE is always on for this. And if DEV_RELEASE is also on it will do a dev release with a dev tag included.
| repository-url: ${{ needs.setup.outputs.pypi_url }} | ||
| skip-existing: ${{ needs.setup.outputs.skip_duplicates }} | ||
| print-hash: true | ||
| repository-url: https://upload.pypi.org/legacy/ |
Contributor
There was a problem hiding this comment.
This is the default and doesn’t need to be set
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few changes here: