[Feature] Additional padding modes#2862
Open
sidtuladhar wants to merge 6 commits intoml-explore:mainfrom
Open
Conversation
Author
|
Hi, could I get a review on this, thanks! @awni |
Author
zcbenz
reviewed
Mar 26, 2026
Collaborator
zcbenz
left a comment
zcbenz
left a comment
There was a problem hiding this comment.
Sorry for the late review, do you mind rebasing this on main branch so we can run tests? The code basically looks good to me.
sidtuladhar
force-pushed
the
feat/padding
branch
from
1656c34 to
8daf383
Compare
Author
|
Done! @zcbenz |
Collaborator
|
The tests are failing. |
sidtuladhar
force-pushed
the
feat/padding
branch
from
8daf383 to
0c4fad3
Compare
Author
|
should be fixed now |
Collaborator
|
The CPP tests are still failing, the python tests are passing so I think there is no problem with the API implementation, we only need to get the test case right. |
Author
|
Gotcha, cpp tests should pass now |
zcbenz
approved these changes
Mar 30, 2026
Collaborator
zcbenz
left a comment
zcbenz
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Hi team, this PR adds
symmetricandreflectpadding modes. It addresses issue #2155Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes