Skip to content

tests: harden memory leak check in test_siblings_without_eval #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zcbenz merged 1 commit into from
Mar 17, 2026
Merged

tests: harden memory leak check in test_siblings_without_eval #3088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/build-macos/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ runs:
run: |
pip install --upgrade pip
pip install cmake setuptools typing_extensions
pip install -e . -v
pip install -e ".[dev]" -v
- name: Install tests dependencies
shell: bash -l {0}
run: |
pip install numpy torch tensorflow
pip install tensorflow
- name: Run Python tests
shell: bash -l {0}
Expand Down
13 changes: 3 additions & 10 deletions python/tests/test_array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,10 @@
from copy import copy, deepcopy
from itertools import permutations

if platform.system() == "Windows":
import psutil
else:
import resource

import mlx.core as mx
import mlx_tests
import numpy as np
import psutil

try:
import tensorflow as tf
Expand Down Expand Up @@ -2087,11 +2083,8 @@ def test_deep_graphs(self):

def test_siblings_without_eval(self):
def get_mem():
if platform.system() == "Windows":
process = psutil.Process(os.getpid())
return process.memory_info().peak_wset
else:
return resource.getrusage(resource.RUSAGE_SELF).ru_maxrss
process = psutil.Process(os.getpid())
return process.memory_info().rss

key = mx.array([1, 2])

Expand Down
Loading